[CodeQuality] Reuse local stub variable when property used 2+ times in single method#702
Merged
Merged
Conversation
…n single method on InlineStubPropertyToCreateStubMethodCallRector
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
InlineStubPropertyToCreateStubMethodCallRectorinlined$this->createStub(...)at every property fetch. When a stub property is used 2+ times in a single method, that produced multiple distinct stub instances — breaking identity checks likespl_object_id($this->formatter).What
Per-method handling in
refactorClassMethod():$this->createStub(...)above the first use, then reuse the variable.Variable name via
resolveVariableName():formatter→$formatterStub; a name already ending inStubis kept as-is (someStub→$someStub).Before
After
Only
Stubproperties are touched;MockObject(createMock) is left untouched.Tests
inline_used_in_calls.php.inc(2 uses → reuses local var).reuse_variable_on_multiple_uses.php.inc.ECS, PHPStan, Rector, and the rule tests all pass.